Discussion:
RFR 8204492 Add deprecation annotation to Nashorn APIs and warning to nashorn, jjs
(too old to reply)
Sundararajan Athijegannathan
2018-06-27 04:16:11 UTC
Permalink
Please review.

Bug https://bugs.openjdk.java.net/browse/JDK-8204492
Webrev http://cr.openjdk.java.net/~sundar/8204492/webrev.01

Related:

JEP http://openjdk.java.net/jeps/335
CSR https://bugs.openjdk.java.net/browse/JDK-8205594

Thanks,
-Sundar
Sundararajan Athijegannathan
2018-06-27 04:19:33 UTC
Permalink
Forgot to CC build-dev for makefile changes.

-Sundar
Post by Sundararajan Athijegannathan
Please review.
Bug https://bugs.openjdk.java.net/browse/JDK-8204492
Webrev http://cr.openjdk.java.net/~sundar/8204492/webrev.01
JEP http://openjdk.java.net/jeps/335
CSR https://bugs.openjdk.java.net/browse/JDK-8205594
Thanks,
-Sundar
Hannes Wallnöfer
2018-06-27 09:42:10 UTC
Permalink
Looks good.

Hannes
Post by Sundararajan Athijegannathan
Forgot to CC build-dev for makefile changes.
-Sundar
Post by Sundararajan Athijegannathan
Please review.
Bug https://bugs.openjdk.java.net/browse/JDK-8204492
Webrev http://cr.openjdk.java.net/~sundar/8204492/webrev.01
JEP http://openjdk.java.net/jeps/335
CSR https://bugs.openjdk.java.net/browse/JDK-8205594
Thanks,
-Sundar
Erik Joelsson
2018-06-27 15:41:45 UTC
Permalink
Hello Sundar,

Adding $(DISABLE_WARNINGS) disables a lot of warnings. Isn't
jdk.scripting.nashorn pretty much warning frree now? What warnings do
you really need to disable?

/Erik
Post by Sundararajan Athijegannathan
Forgot to CC build-dev for makefile changes.
-Sundar
Post by Sundararajan Athijegannathan
Please review.
Bug https://bugs.openjdk.java.net/browse/JDK-8204492
Webrev http://cr.openjdk.java.net/~sundar/8204492/webrev.01
JEP http://openjdk.java.net/jeps/335
CSR https://bugs.openjdk.java.net/browse/JDK-8205594
Thanks,
-Sundar
Sundararajan Athijegannathan
2018-06-27 15:59:02 UTC
Permalink
Hi Erik,

Yes, nashorn is warning free afaik. Besides nashorn is being deprecated.
No further development expected other than perhaps occasional bug fixes.

We need to disable javac deprecation warnings. Without this javac
deprecation warnings cause build failure.

-Sundar
Post by Erik Joelsson
Hello Sundar,
Adding $(DISABLE_WARNINGS) disables a lot of warnings. Isn't
jdk.scripting.nashorn pretty much warning frree now? What warnings do
you really need to disable?
/Erik
Post by Sundararajan Athijegannathan
Forgot to CC build-dev for makefile changes.
-Sundar
Post by Sundararajan Athijegannathan
Please review.
Bug https://bugs.openjdk.java.net/browse/JDK-8204492
Webrev http://cr.openjdk.java.net/~sundar/8204492/webrev.01
JEP http://openjdk.java.net/jeps/335
CSR https://bugs.openjdk.java.net/browse/JDK-8205594
Thanks,
-Sundar
Erik Joelsson
2018-06-27 15:59:53 UTC
Permalink
If it's just deprecation you want to remove, then
-Xlint:all,-deprecation should be enough to add. The current argument
for jdk.scripting.nashorn is -Xlint:all (if I'm not mistaken).

/Erik
Post by Sundararajan Athijegannathan
Hi Erik,
Yes, nashorn is warning free afaik. Besides nashorn is being
deprecated. No further development expected other than perhaps
occasional bug fixes.
We need to disable javac deprecation warnings. Without this javac
deprecation warnings cause build failure.
-Sundar
Post by Erik Joelsson
Hello Sundar,
Adding $(DISABLE_WARNINGS) disables a lot of warnings. Isn't
jdk.scripting.nashorn pretty much warning frree now? What warnings do
you really need to disable?
/Erik
Post by Sundararajan Athijegannathan
Forgot to CC build-dev for makefile changes.
-Sundar
Post by Sundararajan Athijegannathan
Please review.
Bug https://bugs.openjdk.java.net/browse/JDK-8204492
Webrev http://cr.openjdk.java.net/~sundar/8204492/webrev.01
JEP http://openjdk.java.net/jeps/335
CSR https://bugs.openjdk.java.net/browse/JDK-8205594
Thanks,
-Sundar
Sundararajan Athijegannathan
2018-06-28 04:53:22 UTC
Permalink
Only -deprecation still results in build failure :( I'll go with what
I've now to push the change before the deadline -- and we can revisit
better makefile option in a future patch.

Thanks,
-Sundar
Post by Erik Joelsson
If it's just deprecation you want to remove, then
-Xlint:all,-deprecation should be enough to add. The current argument
for jdk.scripting.nashorn is -Xlint:all (if I'm not mistaken).
/Erik
Post by Sundararajan Athijegannathan
Hi Erik,
Yes, nashorn is warning free afaik. Besides nashorn is being
deprecated. No further development expected other than perhaps
occasional bug fixes.
We need to disable javac deprecation warnings. Without this javac
deprecation warnings cause build failure.
-Sundar
Post by Erik Joelsson
Hello Sundar,
Adding $(DISABLE_WARNINGS) disables a lot of warnings. Isn't
jdk.scripting.nashorn pretty much warning frree now? What warnings
do you really need to disable?
/Erik
Post by Sundararajan Athijegannathan
Forgot to CC build-dev for makefile changes.
-Sundar
Post by Sundararajan Athijegannathan
Please review.
Bug https://bugs.openjdk.java.net/browse/JDK-8204492
Webrev http://cr.openjdk.java.net/~sundar/8204492/webrev.01
JEP http://openjdk.java.net/jeps/335
CSR https://bugs.openjdk.java.net/browse/JDK-8205594
Thanks,
-Sundar
Jim Laskey
2018-06-27 11:58:50 UTC
Permalink
+1
Post by Sundararajan Athijegannathan
Please review.
Bug https://bugs.openjdk.java.net/browse/JDK-8204492
Webrev http://cr.openjdk.java.net/~sundar/8204492/webrev.01
JEP http://openjdk.java.net/jeps/335
CSR https://bugs.openjdk.java.net/browse/JDK-8205594
Thanks,
-Sundar
Loading...