RFR [11]: 8194985: JavaAdapterBytecodeGenerator passes invalid type descriptor to ASM

[Hannes Wallnöfer]

Please review:

Bug: https://bugs.openjdk.java.net/browse/JDK-8194985
Webrev: http://cr.openjdk.java.net/~hannesw/8194985/webrev.00/

Thanks,
Hannes

[Sundararajan Athijegannathan]

+1

-Sundar

Post by Hannes Wallnöfer
Bug: https://bugs.openjdk.java.net/browse/JDK-8194985
Webrev: http://cr.openjdk.java.net/~hannesw/8194985/webrev.00/
Thanks,
Hannes

[Attila Szegedi]

+1

That’s a weird thing to make stricter. I guess in anticipation of value types which will use something other than L it can’t just substitute L anymore for anything that’s not a known primitive type name.

Attila.

Post by Sundararajan Athijegannathan
+1
-Sundar

Post by Hannes Wallnöfer
Bug: https://bugs.openjdk.java.net/browse/JDK-8194985
Webrev: http://cr.openjdk.java.net/~hannesw/8194985/webrev.00/
Thanks,
Hannes

[Hannes Wallnöfer]

Actually the old implementation was a bit careless, checking just the first character in a switch statement for primitive and reference types, and then creating a *method* type in the default case, which just happened to work by chance for our checkcast operation. The way it is now is definitely an improvement.

Thanks for the reviews!

Hannes

Post by Attila Szegedi
+1
That’s a weird thing to make stricter. I guess in anticipation of value types which will use something other than L it can’t just substitute L anymore for anything that’s not a known primitive type name.
Attila.

Post by Sundararajan Athijegannathan
+1
-Sundar

Post by Hannes Wallnöfer
Bug: https://bugs.openjdk.java.net/browse/JDK-8194985
Webrev: http://cr.openjdk.java.net/~hannesw/8194985/webrev.00/
Thanks,
Hannes