Discussion:
RFR: 8203814: javac --release=8 \"cannot find symbol\" for NashornException.getEcmaError()
(too old to reply)
Jan Lahoda
2018-06-15 13:47:58 UTC
Permalink
Hi,

The Nashorn APIs have been enhanced in JDK 8 updates. The proposal here
is to update the historical data for --release 8 to JDK 8u40.

Note this includes removal of:
jdk.nashorn.api.scripting.NashornException.ENGINE_SCRIPT_SOURCE_NAME
and:
jdk.nashorn.api.scripting.NashornScriptEngine.__noSuchProperty__(...)
and a change of:
jdk.nashorn.api.scripting.ScriptUtils.wrap(...)

Bug: https://bugs.openjdk.java.net/browse/JDK-8203814
Webrev: http://cr.openjdk.java.net/~jlahoda/8203814/webrev.00/

How does this look?

Thanks,
Jan
Hannes Wallnöfer
2018-06-15 14:52:08 UTC
Permalink
Thanks for helping out with this, Jan.

Unfortunately I found another change that was backported to 8u102 that changes the signatures of ScriptUtils makeSynchronizedFunction(…) and wrap(…) methods (again).

https://bugs.openjdk.java.net/browse/JDK-8148379

I’m sorry about this, I should have checked when you first asked me about it.

Otherwise the patch looks good to me.

Hannes
Hi,
The Nashorn APIs have been enhanced in JDK 8 updates. The proposal here is to update the historical data for --release 8 to JDK 8u40.
jdk.nashorn.api.scripting.NashornException.ENGINE_SCRIPT_SOURCE_NAME
jdk.nashorn.api.scripting.NashornScriptEngine.__noSuchProperty__(...)
jdk.nashorn.api.scripting.ScriptUtils.wrap(...)
Bug: https://bugs.openjdk.java.net/browse/JDK-8203814
Webrev: http://cr.openjdk.java.net/~jlahoda/8203814/webrev.00/
How does this look?
Thanks,
Jan
Jan Lahoda
2018-06-19 11:14:33 UTC
Permalink
Hi Hannes,

Thanks for the comment, updated webrev:
http://cr.openjdk.java.net/~jlahoda/8203814/webrev.01/

(It also includes a few more tweaks that turned out to be needed.)

Jan
Post by Hannes Wallnöfer
Thanks for helping out with this, Jan.
Unfortunately I found another change that was backported to 8u102 that changes the signatures of ScriptUtils makeSynchronizedFunction(…) and wrap(…) methods (again).
https://bugs.openjdk.java.net/browse/JDK-8148379
I’m sorry about this, I should have checked when you first asked me about it.
Otherwise the patch looks good to me.
Hannes
Hi,
The Nashorn APIs have been enhanced in JDK 8 updates. The proposal here is to update the historical data for --release 8 to JDK 8u40.
jdk.nashorn.api.scripting.NashornException.ENGINE_SCRIPT_SOURCE_NAME
jdk.nashorn.api.scripting.NashornScriptEngine.__noSuchProperty__(...)
jdk.nashorn.api.scripting.ScriptUtils.wrap(...)
Bug: https://bugs.openjdk.java.net/browse/JDK-8203814
Webrev: http://cr.openjdk.java.net/~jlahoda/8203814/webrev.00/
How does this look?
Thanks,
Jan
Hannes Wallnöfer
2018-06-19 13:14:16 UTC
Permalink
Hi Jan,

The changes for Nashorn symbols all look good to me.

Thanks,
Hannes
Post by Jan Lahoda
Hi Hannes,
http://cr.openjdk.java.net/~jlahoda/8203814/webrev.01/
(It also includes a few more tweaks that turned out to be needed.)
Jan
Post by Hannes Wallnöfer
Thanks for helping out with this, Jan.
Unfortunately I found another change that was backported to 8u102 that changes the signatures of ScriptUtils makeSynchronizedFunction(…) and wrap(…) methods (again).
https://bugs.openjdk.java.net/browse/JDK-8148379
I’m sorry about this, I should have checked when you first asked me about it.
Otherwise the patch looks good to me.
Hannes
Hi,
The Nashorn APIs have been enhanced in JDK 8 updates. The proposal here is to update the historical data for --release 8 to JDK 8u40.
jdk.nashorn.api.scripting.NashornException.ENGINE_SCRIPT_SOURCE_NAME
jdk.nashorn.api.scripting.NashornScriptEngine.__noSuchProperty__(...)
jdk.nashorn.api.scripting.ScriptUtils.wrap(...)
Bug: https://bugs.openjdk.java.net/browse/JDK-8203814
Webrev: http://cr.openjdk.java.net/~jlahoda/8203814/webrev.00/
How does this look?
Thanks,
Jan
Loading...