Discussion:
RFR: JDK-8203827: Upgrade JLine to 2.14.6
(too old to reply)
Jan Lahoda
2018-05-25 20:20:34 UTC
Permalink
Hi,

I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to 2.14.6.

The complete webrev is here:
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/

To simplify reviewing, there is:
-an antipatch that removes the JDK-specific changes and restores the
vanilla 2.12.1 content:
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/undo-jdk-extras/
-a patch that replaces the 2.12.1 content with 2.14.6:
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/upgrade-jline/
-a patch that re-applies the JDK-specific changes (like including
adjusting packages, and removal/commenting out of usage of features that
would require undesirable dependencies, and any changes that had to be
done to other modules):
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/adding-jdk-extras/

JBS entry: https://bugs.openjdk.java.net/browse/JDK-8203827

How does this look?

Thanks,
Jan
Alan Bateman
2018-05-29 12:51:31 UTC
Permalink
Post by Jan Lahoda
Hi,
I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to 2.14.6.
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/
-an antipatch that removes the JDK-specific changes and restores the
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/undo-jdk-extras/
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/upgrade-jline/
-a patch that re-applies the JDK-specific changes (like including
adjusting packages, and removal/commenting out of usage of features
that would require undesirable dependencies, and any changes that had
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/adding-jdk-extras/
JBS entry: https://bugs.openjdk.java.net/browse/JDK-8203827
How does this look?
The refresh looks okay and I see the package name has been adjusted for
the new files.

Is there an update to src/jdk.internal.le/share/legal/jlink.md?
Minimally I would assume the version at the top of the file needs to be
updated.

-Alan
Jan Lahoda
2018-05-29 14:04:54 UTC
Permalink
Hi,
Post by Alan Bateman
Post by Jan Lahoda
Hi,
I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to 2.14.6.
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/
-an antipatch that removes the JDK-specific changes and restores the
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/undo-jdk-extras/
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/upgrade-jline/
-a patch that re-applies the JDK-specific changes (like including
adjusting packages, and removal/commenting out of usage of features
that would require undesirable dependencies, and any changes that had
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/adding-jdk-extras/
JBS entry: https://bugs.openjdk.java.net/browse/JDK-8203827
How does this look?
The refresh looks okay and I see the package name has been adjusted for
the new files.
Thanks.
Post by Alan Bateman
Is there an update to src/jdk.internal.le/share/legal/jlink.md?
Minimally I would assume the version at the top of the file needs to be
updated.
Yes, it should, I forgot to do that. I'll send an update later.

Jan
Post by Alan Bateman
-Alan
Jan Lahoda
2018-05-30 15:06:48 UTC
Permalink
Hi,

An updated webrev is here:
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.01/complete/

A webrev showing changes from the previous revision is here:
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.01/delta/

The changes are:
-updated src/jdk.internal.le/share/legal/jline.md
-the problem with automatically adding space after completion is resolved
-a few tweaks to tests

Does this look good?

Thanks,
Jan
Post by Jan Lahoda
Hi,
Post by Alan Bateman
Post by Jan Lahoda
Hi,
I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to 2.14.6.
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/
-an antipatch that removes the JDK-specific changes and restores the
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/undo-jdk-extras/
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/upgrade-jline/
-a patch that re-applies the JDK-specific changes (like including
adjusting packages, and removal/commenting out of usage of features
that would require undesirable dependencies, and any changes that had
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/adding-jdk-extras/
JBS entry: https://bugs.openjdk.java.net/browse/JDK-8203827
How does this look?
The refresh looks okay and I see the package name has been adjusted for
the new files.
Thanks.
Post by Alan Bateman
Is there an update to src/jdk.internal.le/share/legal/jlink.md?
Minimally I would assume the version at the top of the file needs to be
updated.
Yes, it should, I forgot to do that. I'll send an update later.
Jan
Post by Alan Bateman
-Alan
Hannes Wallnöfer
2018-05-31 07:26:08 UTC
Permalink
Hi Jan,

Works as expected with jjs now.

Thanks,
Hannes
Post by Jan Lahoda
Hi,
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.01/complete/
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.01/delta/
-updated src/jdk.internal.le/share/legal/jline.md
-the problem with automatically adding space after completion is resolved
-a few tweaks to tests
Does this look good?
Thanks,
Jan
Post by Jan Lahoda
Hi,
Post by Alan Bateman
Post by Jan Lahoda
Hi,
I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to 2.14.6.
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/
-an antipatch that removes the JDK-specific changes and restores the
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/undo-jdk-extras/
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/upgrade-jline/
-a patch that re-applies the JDK-specific changes (like including
adjusting packages, and removal/commenting out of usage of features
that would require undesirable dependencies, and any changes that had
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/adding-jdk-extras/
JBS entry: https://bugs.openjdk.java.net/browse/JDK-8203827
How does this look?
The refresh looks okay and I see the package name has been adjusted for
the new files.
Thanks.
Post by Alan Bateman
Is there an update to src/jdk.internal.le/share/legal/jlink.md?
Minimally I would assume the version at the top of the file needs to be
updated.
Yes, it should, I forgot to do that. I'll send an update later.
Jan
Post by Alan Bateman
-Alan
Alan Bateman
2018-05-31 07:50:51 UTC
Permalink
Post by Jan Lahoda
Hi,
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.01/complete/
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.01/delta/
-updated src/jdk.internal.le/share/legal/jline.md
-the problem with automatically adding space after completion is resolved
-a few tweaks to tests
Does this look good?
I see Hannes has replied and I assume you've tested jshell so I think
this is upgrade is good to go.

-Alan.

Hannes Wallnöfer
2018-05-29 15:32:17 UTC
Permalink
Hi Jan,

Nashorn changes look good.

I noticed one slight change of behaviour in jjs. When I enter „java.m“ and hit the tab key, it autocompletes to „java.math “, adding a space character at the end. This is a bit inconvenient, and the old version of jline didn’t do that.

Hannes
Post by Jan Lahoda
Hi,
I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to 2.14.6.
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/undo-jdk-extras/
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/upgrade-jline/
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/adding-jdk-extras/
JBS entry: https://bugs.openjdk.java.net/browse/JDK-8203827
How does this look?
Thanks,
Jan
Jan Lahoda
2018-05-29 16:11:55 UTC
Permalink
Hi Hannes,
Post by Hannes Wallnöfer
Hi Jan,
Nashorn changes look good.
I noticed one slight change of behaviour in jjs. When I enter „java.m“ and hit the tab key, it autocompletes to „java.math “, adding a space character at the end. This is a bit inconvenient, and the old version of jline didn’t do that.
Thanks for finding that, and sorry I didn't notice (jshell is using its
own completion handler, so did not suffer from this). It should be
possible to disable this in jjs, will do and will send updated webrev.

Thanks,
Jan
Post by Hannes Wallnöfer
Hannes
Post by Jan Lahoda
Hi,
I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to 2.14.6.
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/undo-jdk-extras/
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/upgrade-jline/
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/adding-jdk-extras/
JBS entry: https://bugs.openjdk.java.net/browse/JDK-8203827
How does this look?
Thanks,
Jan
Loading...